On Mon, Jan 03, 2022 at 12:38:21PM +0100, Linus Walleij wrote:
> These IDs were found in the wild in a Sony Xperia vendor tree.
>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> drivers/gpu/drm/panel/panel-novatek-nt35560.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35560.c b/drivers/gpu/drm/panel/panel-novatek-nt35560.c
> index 620876225384..41dc278faf80 100644
> --- a/drivers/gpu/drm/panel/panel-novatek-nt35560.c
> +++ b/drivers/gpu/drm/panel/panel-novatek-nt35560.c
> @@ -32,13 +32,14 @@
> /*
> * Sony seems to use vendor ID 0x81
> */
> -#define DISPLAY_SONY_ACX424AKP_ID1 0x811b
> +#define DISPLAY_SONY_ACX424AKP_ID1 0x8103
> #define DISPLAY_SONY_ACX424AKP_ID2 0x811a
> +#define DISPLAY_SONY_ACX424AKP_ID3 0x811b
> /*
> * The third ID looks like a bug, vendor IDs begin at 0x80
> * and panel 00 ... seems like default values.
> */
This comment needs adjustment s/third/fourth/
With the comment fixed:
Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> -#define DISPLAY_SONY_ACX424AKP_ID3 0x8000
> +#define DISPLAY_SONY_ACX424AKP_ID4 0x8000
>
> struct nt35560 {
> struct drm_panel panel;
> @@ -225,6 +226,7 @@ static int nt35560_read_id(struct nt35560 *nt)
> case DISPLAY_SONY_ACX424AKP_ID1:
> case DISPLAY_SONY_ACX424AKP_ID2:
> case DISPLAY_SONY_ACX424AKP_ID3:
> + case DISPLAY_SONY_ACX424AKP_ID4:
> dev_info(nt->dev, "MTP vendor: %02x, version: %02x, panel: %02x\n",
> vendor, version, panel);
> break;
> --
> 2.31.1
