Re: [PATCH] drm/amdkfd: Fix for possible integer overflow

[Felix Kuehling <felix.kuehling@xxxxxxx>]

Am 2022-02-18 um 18:08 schrieb David Yat Sin:
> Fix for possible integer overflow when doing addition.
>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: David Yat Sin <david.yatsin@xxxxxxx>

Reviewed-by: Felix Kuehling <Felix.Kuehling@xxxxxxx>


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
> index c3f252fc337b..6eca9509f2e3 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
> @@ -786,7 +786,7 @@ int kfd_criu_restore_queue(struct kfd_process *p,
>   	}
>   
>   	*priv_data_offset += sizeof(*q_data);
> -	q_extra_data_size = q_data->ctl_stack_size + q_data->mqd_size;
> +	q_extra_data_size = (uint64_t)q_data->ctl_stack_size + q_data->mqd_size;
>   
>   	if (*priv_data_offset + q_extra_data_size > max_priv_data_size) {
>   		ret = -EINVAL;