Quoting Maxime Ripard (2022-01-25 06:15:42) > The code in clk_set_rate_range() will, if the current rate is outside of > the new range, will force it to the minimum or maximum. This is > equivalent to using clamp, while being less readable. Let's switch to > using clamp instead. > > Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx> > --- > drivers/clk/clk.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index 7bb5ae0fb688..150d1bc0985b 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -2365,11 +2365,7 @@ int clk_set_rate_range(struct clk *clk, unsigned long min, unsigned long max) > * this corner case when determining the rate > */ > > - if (rate < min) > - rate = min; > - else > - rate = max; > - > + rate = clamp(clk->core->req_rate, min, max); This isn't equivalent. The else arm is taken if rate >= min and rate is set to max, whereas clamp() will leave the rate unchanged if rate >= min && rate < max.
