On Thu, Feb 17, 2022 at 04:20:15PM +0300, Dmitry Osipenko wrote:
> 17.02.2022 11:29, Sascha Hauer пишет:
> > + hdmi->ref_clk = devm_clk_get(hdmi->dev, "ref");
> > + if (PTR_ERR(hdmi->ref_clk) == -ENOENT)
> > + hdmi->ref_clk = devm_clk_get(hdmi->dev, "vpll");
> > +
> > + if (PTR_ERR(hdmi->ref_clk) == -ENOENT) {
> > + hdmi->ref_clk = NULL;
>
> I missed in v5 that devm_clk_get_optional() could be used here. But this
> doesn't worth the v7 by itself.
I looked into it and came to the conclusion that I can't use devm_clk_get_optional
for the "ref" clk because then I couldn't do the if (PTR_ERR(hdmi->ref_clk) == -ENOENT)
part.
Looking at it again I could do:
hdmi->ref_clk = devm_clk_get_optional(hdmi->dev, "ref");
if (!hdmi->ref_clk))
hdmi->ref_clk = devm_clk_get_optional(hdmi->dev, "vpll");
I'll change that should I have to resend.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
