Hi Javier, On Fri, Feb 11, 2022 at 1:06 PM Javier Martinez Canillas <javierm@xxxxxxxxxx> wrote: > On 2/11/22 12:33, Andy Shevchenko wrote: > > On Fri, Feb 11, 2022 at 10:19:24AM +0100, Javier Martinez Canillas wrote: > >> This adds a DRM driver for SSD1305, SSD1306, SSD1307 and SSD1309 Solomon > >> OLED display controllers. > >> > >> It's only the core part of the driver and a bus specific driver is needed > >> for each transport interface supported by the display controllers. > >> + bl = devm_backlight_device_register(dev, dev_name(dev), dev, ssd130x, > >> + &ssd130xfb_bl_ops, NULL); > >> + if (IS_ERR(bl)) { > > > >> + ret = PTR_ERR(bl); > >> + dev_err_probe(dev, ret, "Unable to register backlight device\n"); > >> + return ERR_PTR(ret); > > > > dev_err_probe(dev, PTR_ERR(bl), "Unable to register backlight device\n"); > > return bl; > > > > ? > > No, because this function's return value is a struct ssd130x_device pointer, > not a struct backlight_device pointer. Hence return ERR_PTR(dev_err_probe(dev, PTR_ERR(bl), "Unable to register backlight device\n")); ? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds