On Fri, Feb 11, 2022 at 12:43 AM Mario Limonciello <mario.limonciello@xxxxxxx> wrote: > > Currently `pci_is_thunderbolt_attached` is used to indicate a device > is connected externally. > > The PCI core now marks such devices as removable and downstream drivers > can use this instead. > > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx> > --- > drivers/platform/x86/apple-gmux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c > index 04232fbc7d56..ffac15b9befd 100644 > --- a/drivers/platform/x86/apple-gmux.c > +++ b/drivers/platform/x86/apple-gmux.c > @@ -596,7 +596,7 @@ static int gmux_resume(struct device *dev) > > static int is_thunderbolt(struct device *dev, void *data) > { > - return pci_is_thunderbolt_attached(to_pci_dev(dev)); > + return dev_is_removable(dev); > } > Maybe it's only me, but isn't it a bit strange to keep this function named `is_thunderbolt` while it's actually about being removable?