Hi Ville,
Thanks for your review
On Thu, Feb 03, 2022 at 09:59:15PM +0200, Ville Syrjälä wrote:
> > +static int
> > +vc4_hdmi_encoder_compute_clock(const struct vc4_hdmi *vc4_hdmi,
> > + struct vc4_hdmi_connector_state *vc4_state,
> > + const struct drm_display_mode *mode,
> > + unsigned int bpc)
> > +{
> > + unsigned long long clock;
> > +
> > + clock = vc4_hdmi_encoder_compute_mode_clock(mode, bpc);
> > + if (vc4_hdmi_encoder_clock_valid(vc4_hdmi, clock) != MODE_OK)
> > + return -EINVAL;
> > +
> > + vc4_state->pixel_rate = clock;
>
> This thing seems a bit confused between pixels vs. TMDS characters.
> Either that or some/all of the pixel_clock/rate things are just
> misnamed?
Yeah, this is the TMDS characters rate, I'll rename it.
Maxime
Attachment:
signature.asc
Description: PGP signature
