Hi Michael, Am Mittwoch, 9. Februar 2022, 16:46:28 CET schrieb Michael Riesch: > Hi Rob, > > On 2/9/22 16:35, Rob Herring wrote: > > On Wed, 09 Feb 2022 09:51:06 +0100, Michael Riesch wrote: > >> From: Alex Bee <knaerzche@xxxxxxxxx> > >> > >> The Bifrost GPU in Rockchip RK356x SoCs has a core and a bus clock. > >> Reflect this in the SoC specific part of the binding. > >> > >> Signed-off-by: Alex Bee <knaerzche@xxxxxxxxx> > >> [move the changes to the SoC section] > >> Signed-off-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx> > >> --- > >> .../devicetree/bindings/gpu/arm,mali-bifrost.yaml | 15 +++++++++++++++ > >> 1 file changed, 15 insertions(+) > >> > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > ./Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml:173:12: [warning] wrong indentation: expected 12 but found 11 (indentation) > > D'oh! Sorry for the stupid mistake, I found that yamllint was indeed > missing. > > Lines 173 and 174 need an extra space. In the case that a v6 is required > I'll fix this. But of course I wouldn't say no if this could be fixed > when the patch is applied :-) My guess is, Rob's bot filters out the easy wrongs, so I'm not sure if he actually looks at these in person. So doing a v6 might actually be better for a Review :-) Heiko > > > > dtschema/dtc warnings/errors: > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/patch/1590238 > > > > This check can fail if there are any dependencies. The base for a patch > > series is generally the most recent rc1. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit. > > >
