On 2/9/22 16:17, Andy Shevchenko wrote: > On Wed, Feb 09, 2022 at 01:25:46PM +0100, Geert Uytterhoeven wrote: >> On Wed, Feb 9, 2022 at 10:12 AM Javier Martinez Canillas >> <javierm@xxxxxxxxxx> wrote: > > ... > >>> + .compatible = "solomon,ssd1305fb-spi", >> >> This needs an update to the DT bindings. >> Hence this may be a good time to deprecate the existing >> "solomon,ssd130*fb-i2c" compatible values, and switch to >> "solomon,ssd130*fb" instead, for both I2C and SPI. > > Agree! > Did you see my comment about automatic module loading ? I think that would be an issue if we use the same compatible for both I2C and SPI drivers. Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat
