Re: [PATCH] drm/privacy-screen: Fix sphinx warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Thank you for the review.

On 2/7/22 12:43, Simon Ser wrote:
> On Wednesday, January 26th, 2022 at 16:11, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> 
>> - * A pointer to the drm_privacy_screen's struct is passed as the void *data
>> + * A pointer to the drm_privacy_screen's struct is passed as the void \*data
> 
> Maybe we can use @data here instead? It's used to refer to arguments or struct
> members.

It is not an argument to the function being described; nor is it a struct member,
it is the void *data in:

typedef int (*notifier_fn_t)(struct notifier_block *nb,
                        unsigned long action, void *data);


> Alternatively, use double backquotes to format it as inline code blocks:
> 
>    ``void *data``

So I'll prepare a v2 using this.

Regards,

Hans




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux