Hi Kandpal, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on drm-intel/for-linux-next drm-tip/drm-tip v5.17-rc2 next-20220202] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Kandpal-Suraj/drm-writeback-connector-changes/20220202-164832 base: git://anongit.freedesktop.org/drm/drm drm-next config: i386-randconfig-a013-20220131 (https://download.01.org/0day-ci/archive/20220203/202202030437.kmrDD39E-lkp@xxxxxxxxx/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 6b1e844b69f15bb7dffaf9365cd2b355d2eb7579) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/57ad56d769873f62f87fe432243030ceb1678f87 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Kandpal-Suraj/drm-writeback-connector-changes/20220202-164832 git checkout 57ad56d769873f62f87fe432243030ceb1678f87 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> Note: the linux-review/Kandpal-Suraj/drm-writeback-connector-changes/20220202-164832 HEAD 75bbd0a8b1fb58f702279bfbc2fe2d74db8f7028 builds fine. It only hurts bisectability. All errors (new ones prefixed by >>): >> drivers/gpu/drm/vkms/vkms_writeback.c:117:56: error: member reference type 'struct drm_connector *' is a pointer; did you mean to use '->'? struct drm_connector_state *conn_state = wb_conn->base.state; ~~~~~~~~~~~~~^ -> >> drivers/gpu/drm/vkms/vkms_writeback.c:143:38: error: member reference type 'struct drm_encoder *' is a pointer; did you mean to use '->'? vkmsdev->output.wb_connector.encoder.possible_crtcs = 1; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ -> >> drivers/gpu/drm/vkms/vkms_writeback.c:144:27: error: incompatible pointer types passing 'struct drm_connector **' to parameter of type 'struct drm_connector *'; remove & [-Werror,-Wincompatible-pointer-types] drm_connector_helper_add(&wb->base, &vkms_wb_conn_helper_funcs); ^~~~~~~~~ include/drm/drm_modeset_helper_vtables.h:1153:67: note: passing argument to parameter 'connector' here static inline void drm_connector_helper_add(struct drm_connector *connector, ^ 3 errors generated. vim +117 drivers/gpu/drm/vkms/vkms_writeback.c dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 108 dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 109 static void vkms_wb_atomic_commit(struct drm_connector *conn, eca22edb37d29f Maxime Ripard 2020-11-18 110 struct drm_atomic_state *state) dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 111 { eca22edb37d29f Maxime Ripard 2020-11-18 112 struct drm_connector_state *connector_state = drm_atomic_get_new_connector_state(state, eca22edb37d29f Maxime Ripard 2020-11-18 113 conn); dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 114 struct vkms_device *vkmsdev = drm_device_to_vkms_device(conn->dev); dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 115 struct vkms_output *output = &vkmsdev->output; dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 116 struct drm_writeback_connector *wb_conn = &output->wb_connector; dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 @117 struct drm_connector_state *conn_state = wb_conn->base.state; dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 118 struct vkms_crtc_state *crtc_state = output->composer_state; dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 119 dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 120 if (!conn_state) dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 121 return; dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 122 dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 123 vkms_set_composer(&vkmsdev->output, true); dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 124 dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 125 spin_lock_irq(&output->composer_lock); dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 126 crtc_state->active_writeback = conn_state->writeback_job->priv; dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 127 crtc_state->wb_pending = true; dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 128 spin_unlock_irq(&output->composer_lock); eca22edb37d29f Maxime Ripard 2020-11-18 129 drm_writeback_queue_job(wb_conn, connector_state); dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 130 } dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 131 dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 132 static const struct drm_connector_helper_funcs vkms_wb_conn_helper_funcs = { dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 133 .get_modes = vkms_wb_connector_get_modes, dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 134 .prepare_writeback_job = vkms_wb_prepare_job, dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 135 .cleanup_writeback_job = vkms_wb_cleanup_job, dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 136 .atomic_commit = vkms_wb_atomic_commit, dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 137 }; dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 138 dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 139 int vkms_enable_writeback_connector(struct vkms_device *vkmsdev) dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 140 { dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 141 struct drm_writeback_connector *wb = &vkmsdev->output.wb_connector; dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 142 dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 @143 vkmsdev->output.wb_connector.encoder.possible_crtcs = 1; dbd9d80c1b2e03 Rodrigo Siqueira 2020-08-30 @144 drm_connector_helper_add(&wb->base, &vkms_wb_conn_helper_funcs); --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
