Hi Javier, On Tue, Feb 1, 2022 at 12:31 PM Javier Martinez Canillas <javierm@xxxxxxxxxx> wrote: > On 2/1/22 10:37, Andy Shevchenko wrote: > > On Mon, Jan 31, 2022 at 09:56:23PM +0100, Sam Ravnborg wrote: > >> On Mon, Jan 31, 2022 at 09:12:20PM +0100, Javier Martinez Canillas wrote: > > > > ... > > > >>> Patch #3 adds the driver. The name ssd1307 was used instead of ssd130x > >>> (which would be more accurate) to avoid confusion for users who want to > >>> migrate from the existing ssd1307fb fbdev driver. > >> Looking forward the name ssd130x would make more sense. There is only so > >> many existing users and a potential of much more new users. > >> So in my color of the world the naming that benefits the most users > >> wins. > > > > It depends if the binding is going to be preserved. Also this series doesn't > > answer to the question what to do with the old driver. > > > > I don't plan to remove the old driver (yet). My goal here is to have an answer > for Fedora users that might complain that we disabled all the fbdev drivers. > > So I wanted to understand the effort involved in porting a fbdev driver to DRM. > > > If you leave it, I would expect the backward compatibility, otherwise the > > series misses removal of the old driver. > > > > I don't see how those two are correlated. You just need different compatible > strings to match the new and old drivers. That what was usually done for DRM > drivers that were ported. To give an example, the "omapfb" vs "omapdrm". > > Since the current binding has a compatible "ssd1305fb-i2c", we could make the > new one "ssd1305drm-i2c" or better, just "ssd1305-i2c". DT describes hardware, not software policy. If the hardware is the same, the DT bindings should stay the same. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds