Hello Sam,
Thanks for your suggestions.
On 1/31/22 22:30, Sam Ravnborg wrote:
> Hi Javier,
>
> On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote:
>> Add a DRM driver for SSD1305, SSD1306, SSD1307 and SSD1309 Solomon OLED
>> controllers that can be programmed via an I2C interface. This is a port
>> of the ssd1307fb driver that already supports these devices.
>>
>> A Device Tree binding is not added because the DRM driver is compatible
>> with the existing binding for the ssd1307fb driver.
>
> The driver uses the pwms property for the backlight.
> It would have been much better to bite the bullet and require the
> backlight to be specified using a backlight node in the DT.
> This is the standard way to do it and then the driver could use the
> existing backlight driver rather than embedding a backlight driver here.
>
I did consider that. Because that would allow me to use a struct drm_panel
and as you said make the core to manage the backlight. But then decied to
just keep the backward compatibility with the existing binding to make it
easier for users to migrate to the DRM driver.
I wonder if we could make the driver to support both ? That is, to query
if there's a backlight with drm_panel_of_backlight() and if not found then
registering it's own backlight like the driver is currently doing.
> It would cost some backward compatibility - but looking forward this is
> the right thing to do.
>
I don't have a strong opinion. As mentioned I thought that was more worthy
to keep the backward compat over doing it correctly. After all, this driver
is for a very niche hardware (small OLED monochromatic panels), so I wasn't
that concerned about supporting the proper DT conventions.
I would also like to know Andy's opinion. Since he mentioned that embedded
x86/ACPI hardware is using the PRP0001 _DSD extension to match against the
OF driver. I wonder how feasible is for those platforms to change the DSDT.
Another option is to have different compatible strings for this ? I wanted
to drop the "fb" suffix and just have OF entries with compatible "ssd1307"
instead of "ssd1307fb", but again left the latter for backward compat.
But maybe we can have the "fb" ones creating the backlight and the new ones
expecting it to have a backlight DT node.
>>
>> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
>
> Some random comments in the following.
>
> Sam
[snip]
>> +config TINYDRM_SSD1307
>> + tristate "DRM support for Solomon SSD1307 OLED displays"
> Use SSD130X here - so SSD1306 users can find it.
>
Agreed. That's what I had before (and also in the driver, MAINTAINERS entry,
etc) but then changed to SSD1307 everywhere. Unsure what could be more clear
to users grepping to figure out if there's a DRM driver for their device.
I'll follow your suggestion and change in the Kconfig description for v2.
[snip]
>> +
>> +static int ssd1307_fb_blit_rect(struct drm_framebuffer *fb, const struct dma_buf_map *map,
>> + struct drm_rect *rect)
>> +{
>> + struct ssd1307_device *ssd1307 = drm_to_ssd1307(fb->dev);
>> + void *vmap = map->vaddr; /* TODO: Use mapping abstraction properly */
> Hmm, can we fix this TODO now?
>
I did try to fix it while writing the driver but couldn't figure out what was
the proper abstraction to use. Looked at other drivers but *many* do the same
and have the exact same comment :)
$ git grep "TODO: Use mapping abstraction properly" -- drivers/gpu/ | wc -l
15
I'll be happy to fix it if someone could elaborate what this comment expects.
[snip]
>> +
>> + if (!drm_dev_enter(drm, &idx))
>> + return;
>> +
>> + backlight_enable(ssd1307->bl_dev);
> This seems backward - I would have assumed backlight was enabled
> after the display was enabled - so you potentially hide some flickering.
> This is the order done in drm_panel.
>
I see. Sure, I'll change this in v2 as well.
[snip]
>> +
>> + backlight_disable(ssd1307->bl_dev);
> And here backlight could be disabled before disabling the display.
>
Ok.
[snip]
>> +
>> + /* Turn on the display */
>> + ret = ssd1307_write_cmd(ssd1307->client, SSD1307_DISPLAY_ON);
>> + if (ret < 0)
>> + return ret;
> I would assume the display is turned on later - and should be left off
> here. The pipe function will do this when needed.
>
Indeed. I based this on the the ssd1307fb probe logi but forgot to remove
this that's not needed since will be managed by display pipe {en,dis}able.
>> +
>> + return 0;
>> +}
>> +
>> +static int ssd1307_update_bl(struct backlight_device *bdev)
>> +{
>> + struct ssd1307_device *ssd1307 = bl_get_data(bdev);
>> + int brightness = bdev->props.brightness;
> Use backlight_get_brightness(bdev) here.
>
Ok.
>> + int ret;
>> +
>> + ssd1307->contrast = brightness;
>> +
>> + ret = ssd1307_write_cmd(ssd1307->client, SSD1307_CONTRAST);
>> + if (ret < 0)
>> + return ret;
>> +
>> + ret = ssd1307_write_cmd(ssd1307->client, ssd1307->contrast);
>> + if (ret < 0)
>> + return ret;
>> +
>> + return 0;
>> +}
>> +
>> +static int ssd1307_get_brightness(struct backlight_device *bdev)
>> +{
>> + struct ssd1307_device *ssd1307 = bl_get_data(bdev);
>> +
>> + return ssd1307->contrast;
> I am pretty sure this function can be omitted - as the brightness value
> is not changed unless we write it.
>
Gotcha. I will remove this too then.
[snip]
>> +
>> + drm_connector_helper_add(&ssd1307->connector, &ssd1307_connector_helper_funcs);
>> + ret = drm_connector_init(drm, &ssd1307->connector, &ssd1307_connector_funcs,
>> + DRM_MODE_CONNECTOR_Unknown);
> Why not the I2C connector?
>
Doh, I forgot to update the driver after introducing patch 1/4...
[snip]
>> +
>> + snprintf(bl_name, sizeof(bl_name), "ssd1307%d", drm->primary->index);
>> + bl = backlight_device_register(bl_name, dev, ssd1307, &ssd1307fb_bl_ops,
>> + NULL);
> devm_backlight_device_register?
> And use (dev, dev_name(dev), - so you can drop bl_name[]
>
Right. Good suggestion.
[snip]
>> + }
>> +regulator_disable:
>> + if (ssd1307->vbat_reg)
>> + regulator_disable(ssd1307->vbat_reg);
> No need for the if (sd1307->vbat_reg) here.
>
Ok.
[snip]
>> + if (ssd1307->vbat_reg)
>> + regulator_disable(ssd1307->vbat_reg);
> Drop if.
>
Ok.
If you don't mind I'll wait a few days before re-spining v2, in case
others could have more feedback. Thanks a lot again for your review.
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
