On Thu, Jan 20, 2022 at 04:48:50PM +0100, Daniel Vetter wrote: > On Thu, Jan 20, 2022 at 09:16:35AM +0100, Christian König wrote: > > Am 20.01.22 um 00:55 schrieb Ira Weiny: > > > On Wed, Jan 19, 2022 at 06:24:22PM +0100, Daniel Vetter wrote: > > > > On Wed, Jan 19, 2022 at 08:53:56AM -0800, Ira Weiny wrote: > > > > > On Fri, Dec 10, 2021 at 03:23:57PM -0800, 'Ira Weiny' wrote: > > > > > > From: Ira Weiny <ira.weiny@xxxxxxxxx> > > > > > > > > > > > > This series starts by converting the last easy kmap() uses to > > > > > > kmap_local_page(). > > > > > > > > > > > > There is one more call to kmap() wrapped in ttm_bo_kmap_ttm(). Unfortunately, > > > > > > ttm_bo_kmap_ttm() is called in a number of different ways including some which > > > > > > are not thread local. I have a patch to convert that call. However, it is not > > > > > > straight forward so it is not included in this series. > > > > > > > > > > > > The final 2 patches fix bugs found while working on the ttm_bo_kmap_ttm() > > > > > > conversion. > > > > > Gentile ping on this series? Will it make this merge window? > > > > I think this fell through the cracks and so no. Note that generally we > > > > feature-freeze drm tree around -rc6 anyway for the upcoming merge window, > > > > so you were cutting this all a bit close anyway. > > > Ok, No problem. I just had not heard if this was picked up or not. > > > > > > > Also looks like the ttm > > > > kmap caching question didn't get resolved? > > > I'm sorry I thought it was resolve for this series. Christian said the patches > > > in this series were "a good bug fix" even if not strictly necessary.[1] Beyond > > > this series I was discussing where to go from here, and is it possible to go > > > further with more changes.[2] At the moment I don't think I will. > > > > > > Christian did I misunderstand? I can drop patch 6 and 7 if they are not proper > > > bug fixes or at least clarifications to the code. > > > > Yeah, it is indeed a correct cleanup. I would just *not* put a CC stable on > > it because it doesn't really fix anything. > > Ok can you pls get the amd/radeon ones stuffed into alex' tree? Or do we > want to put all the ttm ones into drm-misc instead? I just updated to the latest master and there is a minor conflict. Since this is not going in this window. Let me rebase and resend. Ira > -Daniel >