On 1/18/22 20:00, Javier Martinez Canillas wrote: > Hello Zack, > > On 1/17/22 19:03, Zack Rusin wrote: >> From: Zack Rusin <zackr@xxxxxxxxxx> >> >> When sysfb_simple is enabled loading vmwgfx fails because the regions >> are held by the platform. In that case remove_conflicting*_framebuffers >> only removes the simplefb but not the regions held by sysfb. >> > > Indeed, that's an issue. I wonder if we should drop the IORESOURCE_BUSY > flag from the memory resource added to the "simple-framebuffer" device ? > > In fact, maybe in sysfb_create_simplefb() shouldn't even attempt to claim > a memory resource and just register the platform device with no resources ? > Answering my own question, this would mean adding that platform specific logic to the drivers matching the "simple-framebuffer" device so it should remain in sysfb_create_simplefb(). But I still wonder if dropping the IORESOURCE_BUSY flag is something that will be reasonable to prevent other drivers having the the issue reported in this patch. Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat
