On 1/18/22 17:52, Jocelyn Falempe wrote: > On 18/01/2022 17:38, Javier Martinez Canillas wrote: >> Hello Jocelyn, >> >> On 1/14/22 10:47, Jocelyn Falempe wrote: > >> >> My worry is if this could cause other issues so I would only do this change >> if (is_kdump_kernel()), to make it as non intrusive as possible. And also >> add a verbose comment about why this is needed. > > This change must be done in the "first" kernel, so that when kdump > starts, it doesn't hang the machine by writing to the VGA interface, in > the early boot code. > Ah, got it. The patch then makes sense to me as is in that case. My comment about documenting why this is needed still applies though. Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat