Re: [PATCH v2] Remove extra device acquisition method of i2c client in lt9611 driver

[Zhiming Liu <lzmlzmhh@xxxxxxxxx>]

Hi Robert,

Sure, i have sent the v3 of this patch.

So thankful for your guidance!

Best Regards

Zhiming

Robert Foss <robert.foss@xxxxxxxxxx> 于2022年1月17日周一 23:23写道：

Hey Zhiming,

Again, I think the code is good, but let's fix some small stuff with
the patch submission and then I'll happily apply this.

On Thu, 13 Jan 2022 at 13:52, Zhiming Liu <lzmlzmhh@xxxxxxxxx> wrote:
>
> Signed-off-by: Zhiming Liu <lzmlzmhh@xxxxxxxxx>

The tags like Signed-off-by come after the body of the commit message.

>
> bridge : drm : Remove extra device acquisition method of i2c client in lt9611 driver.

This line has to come first, since it is the title of the commit message.

>
> We have get the device of i2c client in probe function.So we should
> remove extra device acquisition method of i2c client.

^^^ this is the body of the commit message.

Put the tags like Signed-off-by here.

> ---
>  drivers/gpu/drm/bridge/lontium-lt9611.c    | 4 ++--
>  drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index dafb1b47c15f..feb128a4557d 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
>         if (!lt9611)
>                 return -ENOMEM;
>
> -       lt9611->dev = &client->dev;
> +       lt9611->dev = dev;
>         lt9611->client = client;
>         lt9611->sleep = false;
>
> @@ -1100,7 +1100,7 @@ static int lt9611_probe(struct i2c_client *client,
>                 return PTR_ERR(lt9611->regmap);
>         }
>
> -       ret = lt9611_parse_dt(&client->dev, lt9611);
> +       ret = lt9611_parse_dt(dev, lt9611);
>         if (ret) {
>                 dev_err(dev, "failed to parse device tree\n");
>                 return ret;
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> index 33f9716da0ee..3d62e6bf6892 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> @@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
>         if (!lt9611uxc)
>                 return -ENOMEM;
>
> -       lt9611uxc->dev = &client->dev;
> +       lt9611uxc->dev = dev;
>         lt9611uxc->client = client;
>         mutex_init(&lt9611uxc->ocm_lock);
>
> @@ -870,7 +870,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
>                 return PTR_ERR(lt9611uxc->regmap);
>         }
>
> -       ret = lt9611uxc_parse_dt(&client->dev, lt9611uxc);
> +       ret = lt9611uxc_parse_dt(dev, lt9611uxc);
>         if (ret) {
>                 dev_err(dev, "failed to parse device tree\n");
>                 return ret;
> --
> 2.25.1
>