Hey Hsin-Yi,
On Thu, 13 Jan 2022 at 09:29, Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> wrote:
>
> Use devm_kzalloc instead of kzalloc and drop kfree(). Let the memory
> handled by driver detach.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx>
> Reviewed-by: Xin Ji <xji@xxxxxxxxxxxxxxxx>
> ---
> v2->v3: remove kfree() in anx7625_i2c_remove().
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 0b858c78abe8b6..d3661c78770a8f 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -2515,7 +2515,7 @@ static int anx7625_i2c_probe(struct i2c_client *client,
> return -ENODEV;
> }
>
> - platform = kzalloc(sizeof(*platform), GFP_KERNEL);
> + platform = devm_kzalloc(dev, sizeof(*platform), GFP_KERNEL);
> if (!platform) {
> DRM_DEV_ERROR(dev, "fail to allocate driver data\n");
> return -ENOMEM;
> @@ -2527,7 +2527,7 @@ static int anx7625_i2c_probe(struct i2c_client *client,
> if (ret) {
> if (ret != -EPROBE_DEFER)
> DRM_DEV_ERROR(dev, "fail to parse DT : %d\n", ret);
> - goto free_platform;
> + return ret;
> }
>
> platform->client = client;
> @@ -2552,7 +2552,7 @@ static int anx7625_i2c_probe(struct i2c_client *client,
> if (!platform->hdcp_workqueue) {
> dev_err(dev, "fail to create work queue\n");
> ret = -ENOMEM;
> - goto free_platform;
> + return ret;
> }
>
> platform->pdata.intp_irq = client->irq;
> @@ -2637,9 +2637,6 @@ static int anx7625_i2c_probe(struct i2c_client *client,
> if (platform->hdcp_workqueue)
> destroy_workqueue(platform->hdcp_workqueue);
>
> -free_platform:
> - kfree(platform);
> -
> return ret;
> }
>
> @@ -2666,7 +2663,6 @@ static int anx7625_i2c_remove(struct i2c_client *client)
> if (platform->pdata.audio_en)
> anx7625_unregister_audio(platform);
>
> - kfree(platform);
> return 0;
> }
>
I just had a look at applying this series, but it fails to apply on
drm-misc-next today.
Could you send a v4 that applies cleanly, and I'll try to be quick
about applying it.
Rob.
