Re: [PATCH][RESEND] i915: make array flex_regs static const

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 13/01/2022 09:21, Jani Nikula wrote:
On Wed, 12 Jan 2022, Colin Ian King <colin.i.king@xxxxxxxxx> wrote:
Don't populate the read-only array flex_regs on the stack but
instead it static const. Also makes the object code a little smaller.

Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

---

RESEND: Use correct e-mail address for sign-off and From: in e-mail.

There are a number of things at play here:

- Our tooling checks for certain things, such as author/signed-off-by
   match, after applying the patch.

- You have an entry in the kernel git .mailmap.

- The git log.mailmap config default has changed from false to true.

We apply the patch, and, with the default options, git show will display
a different author than the signed-off-by.

We should use --no-use-mailmap when examining a commit to ensure the
commit is internally consistent, regardless of .mailmap.

Yes that sounds like the right thing to do.

In the meantime I have pushed this patch.

Regards,

Tvrtko




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux