Hi Geert, Thanks for the feedback. > Subject: Re: [RFC 22/28] drm: rcar-du: Add RZ/G2L DSI driver > > Hi Biju, > > On Wed, Jan 12, 2022 at 6:47 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > wrote: > > This driver supports the MIPI DSI encoder found in the RZ/G2L SoC. It > > currently supports DSI mode only. > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > Thanks for your patch! > > > --- a/drivers/gpu/drm/rcar-du/Kconfig > > +++ b/drivers/gpu/drm/rcar-du/Kconfig > > @@ -51,6 +51,13 @@ config DRM_RCAR_MIPI_DSI > > help > > Enable support for the R-Car Display Unit embedded MIPI DSI > encoders. > > > > +config DRM_RZG2L_MIPI_DSI > > + tristate "RZ/G2L MIPI DSI Encoder Support" > > + depends on DRM && DRM_BRIDGE && OF > > I guess the dependency on DRM can be dropped, as it is implied by > DRM_BRIDGE? Yes DRM_BRIDGE depends on DRM, so DRM can be dropped here. > > Please add "depends on ARCH_RENESAS || COMPILE_TEST". OK Cheers, Biju > > > + select DRM_MIPI_DSI > > + help > > + Enable support for the RZ/G2L Display Unit embedded MIPI DSI > encoders. > > + > > config DRM_RCAR_VSP > > bool "R-Car DU VSP Compositor Support" if ARM > > default y if ARM64 > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. > But when I'm talking to journalists I just say "programmer" or something > like that. > -- Linus Torvalds