On 12/16/21 22:09, Javier Martinez Canillas wrote:
> The commit feeb07d0ca5a ("drm/hisilicon/hibmc: Make CONFIG_DRM_HISI_HIBMC
> depend on ARM64") made the driver Kconfig symbol to depend on ARM64 since
> it only supports that architecture and loading the module on others would
> lead to incorrect video modes being used.
>
> But it also prevented the driver to be built on other architectures which
> is useful to have compile test coverage when doing subsystem wide changes.
>
> Make the dependency instead to be (ARM64 || COMPILE_TEST), so the driver
> is buildable when the CONFIG_COMPILE_TEST option is enabled.
>
> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> ---
>
> drivers/gpu/drm/hisilicon/hibmc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/Kconfig b/drivers/gpu/drm/hisilicon/hibmc/Kconfig
> index 43943e980203..073adfe438dd 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/Kconfig
> +++ b/drivers/gpu/drm/hisilicon/hibmc/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config DRM_HISI_HIBMC
> tristate "DRM Support for Hisilicon Hibmc"
> - depends on DRM && PCI && ARM64
> + depends on DRM && PCI && (ARM64 || COMPILE_TEST)
> select DRM_KMS_HELPER
> select DRM_VRAM_HELPER
> select DRM_TTM
Any comments on this patch?
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
