Hi Melissa, On Sun, Jan 09, 2022 at 04:48:17PM -0100, Melissa Wen wrote: > On 01/06, Miaoqian Lin wrote: > > The pm_runtime_enable will increase power disable depth. > > If the probe fails, we should use pm_runtime_disable() to balance > > pm_runtime_enable(). > > > > if (ret) > > - goto dma_free; > > + goto pm_disable; > > > > ret = v3d_irq_init(v3d); > > if (ret) > > @@ -298,7 +298,8 @@ static int v3d_platform_drm_probe(struct platform_device *pdev) > > v3d_irq_disable(v3d); > > gem_destroy: > > v3d_gem_destroy(drm); > > -dma_free: > > +pm_disable: > > + pm_runtime_disable(dev); > > Hi, > > I see this pm_runtime_disable balancing is also missing for > v3d_platform_drm_remove(), right? > I think, yes. > > dma_free_wc(dev, 4096, v3d->mmu_scratch, v3d->mmu_scratch_paddr); > > return ret; > > } > > -- > > 2.17.1 > >
