Il 04/01/22 09:01, Yunfei Dong ha scritto:
MT8173 platform use vpu firmware, mt8183/mt8192 will use scp firmware instead, using chip name is not reasonable to separate different firmware architecture. Using firmware type is much better. Signed-off-by: Yunfei Dong <yunfei.dong@xxxxxxxxxxxx> Reviewed-by: Tzung-Bi Shih<tzungbi@xxxxxxxxxx>
Hello Yunfei, I agree with this change, it looks better as it separates behaviors in a more generic way. Anyway, it looks like you're removing all users of `enum mtk_chip` but, in this case, you forgot to also remove the declaration of this enumeration from mtk_vcodec_drv.h! :) Can you please send a v4 with the requested removal? so, for v4... Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
