Hi Fabio,
Thank you for the patch.
On Thu, Dec 30, 2021 at 10:39:29PM -0300, Fabio Estevam wrote:
> Use the atomic version of the enable/disable operations to continue the
> transition to the atomic API, started with the introduction of
> .atomic_get_input_bus_fmts(). This will be needed to access the mode
> from the atomic state.
>
> Based on Laurent's commit a6ea7d268a63("drm: bridge: ti-sn65dsi83:
> Switch to atomic operations").
>
> Tested on a imx6sx-udoo-neo board.
>
> Suggested-by: Marek Vasut <marex@xxxxxxx>
> Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx>
With the comment from 2/2 taken into account,
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/i2c/tda998x_drv.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
> index b7ec6c374fbd..adaa985af87e 100644
> --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> @@ -1395,7 +1395,8 @@ static enum drm_mode_status tda998x_bridge_mode_valid(struct drm_bridge *bridge,
> return MODE_OK;
> }
>
> -static void tda998x_bridge_enable(struct drm_bridge *bridge)
> +static void tda998x_bridge_atomic_enable(struct drm_bridge *bridge,
> + struct drm_bridge_state *old_bridge_state)
> {
> struct tda998x_priv *priv = bridge_to_tda998x_priv(bridge);
>
> @@ -1413,7 +1414,8 @@ static void tda998x_bridge_enable(struct drm_bridge *bridge)
> }
> }
>
> -static void tda998x_bridge_disable(struct drm_bridge *bridge)
> +static void tda998x_bridge_atomic_disable(struct drm_bridge *bridge,
> + struct drm_bridge_state *old_bridge_state)
> {
> struct tda998x_priv *priv = bridge_to_tda998x_priv(bridge);
>
> @@ -1680,9 +1682,9 @@ static const struct drm_bridge_funcs tda998x_bridge_funcs = {
> .attach = tda998x_bridge_attach,
> .detach = tda998x_bridge_detach,
> .mode_valid = tda998x_bridge_mode_valid,
> - .disable = tda998x_bridge_disable,
> + .atomic_disable = tda998x_bridge_atomic_disable,
> .mode_set = tda998x_bridge_mode_set,
> - .enable = tda998x_bridge_enable,
> + .atomic_enable = tda998x_bridge_atomic_enable,
> };
>
> /* I2C driver functions */
--
Regards,
Laurent Pinchart
