Hello Gerd, On 12/22/21 11:21, Gerd Hoffmann wrote: > On Wed, Dec 22, 2021 at 09:28:24AM +0100, Javier Martinez Canillas wrote: >> -static int __init bochs_init(void) >> -{ >> - if (drm_firmware_drivers_only() && bochs_modeset == -1) >> - return -EINVAL; > > Also cleanup bochs_modeset? I guess its not used any more after this > patch ... > That's still used. It is passed as an argument to the macro: drm_module_pci_driver_if_modeset(bochs_pci_driver, bochs_modeset); Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat