On 12/10/2021 4:07 PM, Daniele Ceraolo Spurio wrote:
Some of the newer platforms use a bigger RSA key to authenticate the GuC, which is provided to the HW via a ggtt-pinned object instead of mmio. While doing the changes for this I've also spotted an inconsistency in the error status of the fw on init failure, so I've added a path to fix that as well. v2: clarify in comments that the expected RSA size is hardcoded in the bootrom (Matt)
I've confirmed with Matt that he's ok with the updated comment and pushed. Daniele
Cc: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> Cc: John Harrison <John.C.Harrison@xxxxxxxxx> Cc: Matthew Brost <matthew.brost@xxxxxxxxx> Daniele Ceraolo Spurio (2): drm/i915/uc: correctly track uc_fw init failure drm/i915/guc: support bigger RSA keys Michal Wajdeczko (1): drm/i915/uc: Prepare for different firmware key sizes drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 33 ++++++-- drivers/gpu/drm/i915/gt/uc/intel_huc.c | 75 +----------------- drivers/gpu/drm/i915/gt/uc/intel_huc.h | 2 - drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 95 ++++++++++++++++++++--- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h | 18 +++-- 5 files changed, 128 insertions(+), 95 deletions(-)