Am Mittwoch, 8. Dezember 2021, 16:12:19 CET schrieb Sascha Hauer: > "vpll" is a misnomer. A clock input to a device should be named after > the usage in the device, not after the clock that drives it. On the > rk3568 the same clock is driven by the HPLL. > To fix that, this patch renames the vpll clock to ref clock. The clock > name "vpll" is left for compatibility to old device trees. Can't we just say that the binding only takes the "ref" name, but the code still allows "vpll". I think I remember Rob suggesting something similar in the past. I don't think that we need to keep the binding(-validation) compatible with old devicetrees, but the kernel itself should stay compatible. Heiko > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > --- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > index 6e09dd2ee05ac..2ab6578033da2 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > @@ -48,10 +48,14 @@ properties: > - cec > - grf > - vpll > + - ref > - enum: > - grf > - vpll > - - const: vpll > + - ref > + - enum: > + - vpll > + - ref > > ddc-i2c-bus: > $ref: /schemas/types.yaml#/definitions/phandle >
