Hi,
On Fri, Dec 10, 2021 at 11:18:17PM +0530, Jagan Teki wrote:
> panel_bridge pointer never used anywhere except the one it
> looked up at nwl_dsi_bridge_attach.
>
> Drop it from the nwl_dsi structure.
>
> Cc: Guido Günther <agx@xxxxxxxxxxx>
> Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
Reviewed-by: Guido Günther <agx@xxxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/nwl-dsi.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c
> index a7389a0facfb..6becdcdc99fe 100644
> --- a/drivers/gpu/drm/bridge/nwl-dsi.c
> +++ b/drivers/gpu/drm/bridge/nwl-dsi.c
> @@ -65,7 +65,6 @@ struct nwl_dsi_transfer {
> struct nwl_dsi {
> struct drm_bridge bridge;
> struct mipi_dsi_host dsi_host;
> - struct drm_bridge *panel_bridge;
> struct device *dev;
> struct phy *phy;
> union phy_configure_opts phy_cfg;
> @@ -924,13 +923,11 @@ static int nwl_dsi_bridge_attach(struct drm_bridge *bridge,
> if (IS_ERR(panel_bridge))
> return PTR_ERR(panel_bridge);
> }
> - dsi->panel_bridge = panel_bridge;
>
> - if (!dsi->panel_bridge)
> + if (!panel_bridge)
> return -EPROBE_DEFER;
>
> - return drm_bridge_attach(bridge->encoder, dsi->panel_bridge, bridge,
> - flags);
> + return drm_bridge_attach(bridge->encoder, panel_bridge, bridge, flags);
> }
>
> static void nwl_dsi_bridge_detach(struct drm_bridge *bridge)
> --
> 2.25.1
>
