On Fri, Dec 10, 2021 at 02:21:53AM +0200, Andi Shyti wrote: > Hi Matt, > > > > -static inline struct intel_pxp *i915_dev_to_pxp(struct device *i915_kdev) > > > +static struct intel_pxp *i915_dev_to_pxp(struct device *i915_kdev) > > > > Was dropping the inline here intentional? It doesn't seem like there's > > any reason to drop it, and if it was intentional the whitespace isn't > > quite right. > > No, it wasn't intentional and it's strange that checkpatch > didn't catch it. I will resend this one. With the 'inline' re-added, you can include Reviewed-by: Matt Roper <matthew.d.roper@xxxxxxxxx> > > Thanks! > Andi -- Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795