Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH 4/6] dt-bindings: gpu: mali-bifrost: Document RZ/G2L
> support
>
> Hi Biju,
>
> On Fri, Dec 3, 2021 at 12:52 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > The Renesas RZ/G2{L, LC} SoC (a.k.a R9A07G044) has a Bifrost Mali-G31
> > GPU, add a compatible string for it.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
>
> > @@ -52,7 +64,8 @@ properties:
> > maxItems: 3
> >
> > resets:
> > - maxItems: 2
> > + minItems: 1
>
> 2, as before?
OK. Will do.
>
> > + maxItems: 3
>
> Perhaps you should add reset-names?
Agreed. Will remove max items add reset-names instead ("rst", "axi_rst", "ace_rst")
>
> >
> > "#cooling-cells":
> > const: 2
> > @@ -113,6 +126,21 @@ allOf:
> > - sram-supply
> > - power-domains
> > - power-domain-names
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: renesas,r9a07g044-mali
> > + then:
> > + properties:
> > + interrupt-names:
> > + minItems: 4
> > + clock-names:
> > + minItems: 3
> > + required:
> > + - clock-names
> > + - power-domains
> > + - resets
>
> reset-names
Ok.
Regards,
Biju
>
> > else:
> > properties:
> > power-domains:
>
> The rest looks good to me, but I'm no Mali expert.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
> -- Linus Torvalds
