[PATCH 00/11] drm/vc4: hdmi: Yet Another Approach to HDMI YUV output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

This is another attempt at supporting the HDMI YUV output in the vc4 HDMI
driver.

This is a follow-up of
https://lore.kernel.org/dri-devel/20210317154352.732095-1-maxime@xxxxxxxxxx/

And the discussions that occured recently on the mailing lists and IRC about
this.

The series mentioned above had multiple issues, the main one being that it was
a bit too much complicated for what we wanted to achieve. This series is taking
a much simpler approach with an ad-hoc solution.

I think some parts of it could still be moved to KMS helpers (notably, the
output format enum, and the helper to set the infoframe for it) and structures
(the output format stored in drm_connector_state). This would also interact
nicely with the work done here:

https://lore.kernel.org/dri-devel/20211118103814.524670-1-maxime@xxxxxxxxxx/

This can come as a second step though.

The other issues with the first attempt was that nothing was reported to
userspace about the decision we made about the format, and that this decision
was essentially policy, without any way for the userspace to influence it.

Those two points however are being worked on by Werner in a cross-driver
effort:

https://lore.kernel.org/dri-devel/e452775c-5b95-bbfd-e818-f1480f556336@xxxxxxxxxxxxxxxxxxx/

Since it's a KMS decision, I don't think we should hold off any driver as long
as it's consistent with what the other drivers are doing.

Let me know what you think,
Maxime

Maxime Ripard (11):
  drm/edid: Rename drm_hdmi_avi_infoframe_colorspace to _colorimetry
  drm/vc4: hdmi: Add full range RGB helper
  drm/vc4: hdmi: Use full range helper in csc functions
  drm/vc4: hdmi: Move XBAR setup to csc_setup
  drm/vc4: hdmi: Replace CSC_CTL hardcoded value by defines
  drm/vc4: hdmi: Define colorspace matrices
  drm/vc4: hdmi: Change CSC callback prototype
  drm/vc4: hdmi: Move clock validation to its own function
  drm/vc4: hdmi: Move clock calculation into its own function
  drm/vc4: hdmi: Support HDMI YUV output
  drm/vc4: hdmi: Force YUV422 if the rate is too high

 drivers/gpu/drm/drm_edid.c                  |   8 +-
 drivers/gpu/drm/i915/display/intel_hdmi.c   |   2 +-
 drivers/gpu/drm/i915/display/intel_lspcon.c |   2 +-
 drivers/gpu/drm/vc4/vc4_hdmi.c              | 324 +++++++++++++++-----
 drivers/gpu/drm/vc4/vc4_hdmi.h              |  13 +-
 drivers/gpu/drm/vc4/vc4_hdmi_regs.h         |   6 +
 drivers/gpu/drm/vc4/vc4_regs.h              |  19 ++
 include/drm/drm_edid.h                      |   4 +-
 8 files changed, 290 insertions(+), 88 deletions(-)

-- 
2.33.1





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux