On Fri, Nov 26, 2021 at 04:43:49PM +0100, Maxime Ripard wrote: > Hi Daniel, > > On Fri, Nov 19, 2021 at 05:01:14PM +0100, Daniel Vetter wrote: > > On Thu, Nov 18, 2021 at 11:38:01AM +0100, Maxime Ripard wrote: > > > This is a follow-up of the work to support the interactions between the hotplug > > > and the scrambling support for vc4: > > > > > > https://lore.kernel.org/dri-devel/20210507150515.257424-11-maxime@xxxxxxxxxx/ > > > https://lore.kernel.org/dri-devel/20211025152903.1088803-10-maxime@xxxxxxxxxx/ > > > > > > Ville feedback was that the same discussion happened some time ago for i915, > > > and resulted in a function to do an full disable/enable cycle on reconnection > > > to avoid breaking the HDMI 2.0 spec. > > > > > > This series improves the current scrambling support by adding generic helpers > > > for usual scrambling-related operations, and builds upon them to provide a > > > generic alternative to intel_hdmi_reset_link. > > > > Out of curiosity, can we rebuild intel_hdmi_reset_link on top of these? > > Always better to have two drivers to actually show the helpers help, than > > just one. > > Unfortunately, I don't have any Intel system I can test it on, and it > looks like the changes wouldn't be trivial. > > Maybe we can use dw-hdmi instead? Hm I guess so, maybe Ville can be motivated. Just figured since this seems at least inspired by i915 code. Also we have CI running on intel-gfx, so if you just type well enough it generally works out and CI catches anything you got wrong. Christian König is pretty good at not breaking i915 with all the dma-buf and ttm changes nowadays, much better than random arm socs dying. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
