[drm-exynos:exynos-drm-next 1/3] drivers/gpu/drm/exynos/exynos_drm_dsi.c:1338:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true

[kernel test robot <lkp@xxxxxxxxx>]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next
head:   ef1a179ae8eba0aeaac239a28ecdd0700412052a
commit: 84d977a69917c18c9e0a65ed16b43dc889fdd97c [1/3] drm/exynos: Replace legacy gpio interface for gpiod interface
config: riscv-randconfig-r006-20211122 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c133fb321f7ca6083ce15b6aa5bf89de6600e649)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git/commit/?id=84d977a69917c18c9e0a65ed16b43dc889fdd97c
        git remote add drm-exynos https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git
        git fetch --no-tags drm-exynos exynos-drm-next
        git checkout 84d977a69917c18c9e0a65ed16b43dc889fdd97c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/exynos/exynos_drm_dsi.c:1338:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
           if (IS_ERR(dsi->te_gpio)) {
               ^~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/exynos/exynos_drm_dsi.c:1355:9: note: uninitialized use occurs here
           return ret;
                  ^~~
   drivers/gpu/drm/exynos/exynos_drm_dsi.c:1338:2: note: remove the 'if' if its condition is always false
           if (IS_ERR(dsi->te_gpio)) {
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/exynos/exynos_drm_dsi.c:1334:9: note: initialize the variable 'ret' to silence this warning
           int ret;
                  ^
                   = 0
   1 warning generated.


vim +1338 drivers/gpu/drm/exynos/exynos_drm_dsi.c

  1330	
  1331	static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi,
  1332					      struct device *panel)
  1333	{
  1334		int ret;
  1335		int te_gpio_irq;
  1336	
  1337		dsi->te_gpio = devm_gpiod_get_optional(dsi->dev, "te", GPIOD_IN);
> 1338		if (IS_ERR(dsi->te_gpio)) {
  1339			dev_err(dsi->dev, "gpio request failed with %ld\n",
  1340					PTR_ERR(dsi->te_gpio));
  1341			goto out;
  1342		}
  1343	
  1344		te_gpio_irq = gpiod_to_irq(dsi->te_gpio);
  1345	
  1346		ret = request_threaded_irq(te_gpio_irq, exynos_dsi_te_irq_handler, NULL,
  1347					   IRQF_TRIGGER_RISING | IRQF_NO_AUTOEN, "TE", dsi);
  1348		if (ret) {
  1349			dev_err(dsi->dev, "request interrupt failed with %d\n", ret);
  1350			gpiod_put(dsi->te_gpio);
  1351			goto out;
  1352		}
  1353	
  1354	out:
  1355		return ret;
  1356	}
  1357	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip