On Fri, Nov 19, 2021 at 11:20:13AM +0100, Javier Martinez Canillas wrote: > [ adding gregkh to Cc list for drivers/video/console ] > > On 11/12/21 14:32, Javier Martinez Canillas wrote: > > The "nomodeset" kernel cmdline parameter is handled by the vgacon driver > > but the exported vgacon_text_force() symbol is only used by DRM drivers. > > > > It makes much more sense for the parameter logic to be in the subsystem > > of the drivers that are making use of it. > > > > Let's move the vgacon_text_force() function and related logic to the DRM > > subsystem. While doing that, rename it to drm_firmware_drivers_only() and > > make it return true if "nomodeset" was used and false otherwise. This is > > a better description of the condition that the drivers are testing for. > > > > Suggested-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > > Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> > > Acked-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > > Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx> > > Acked-by: Pekka Paalanen <pekka.paalanen@xxxxxxxxxxxxx> > > --- > > > > Greg, could I please get your ack for this patch ? Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
