Re: [PATCH 2/3] drm/vmwgfx: Copy DRM hash-table code into driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

Am 15.11.21 um 18:00 schrieb Zack Rusin:
On Mon, 2021-11-15 at 13:55 +0100, Thomas Zimmermann wrote:
Besides some legacy code, vmwgfx is the only user of DRM's hash-
table implementation. Copy the code into the driver, so that the
core code can be retired.

No functional changes. However, the real solution for vmwgfx is to
use Linux' generic hash-table functions.

The change looks good. fwiw I'd appreciate a heads up for changes like
that because VMware is building up a kernel team and replacing
drm_open_hash with the hasttable.h would be a great task for our new
team. I mean it still is but we could have done it in sync (replace
drm_open_hash with hashtable in vmwgfx and remove drm_open_hash) rather
than having a transitional release.

I don't mind coordinating the work better, but I'm not sure how well this actually works in practice.

There's been recently a push towards full-DRM graphics and abandoning fbdev entirely. That's one of my goals at Suse and Javier works on a similar task on the Redhat side. Reducing the minimum size of the DRM core is one of the tasks. The patchset helps with that.

But our schedules usually revolve around distro releases. And it's hard to synchronize with outside tasks. Training your kernel might take longer or might go quickly.

Best regards
Thomas


z


--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux