Hi Sam Am 15.11.21 um 17:27 schrieb Sam Ravnborg:
Hi Thomas, On Mon, Nov 15, 2021 at 01:55:38PM +0100, Thomas Zimmermann wrote:Besides some legacy code, vmwgfx is the only user of DRM's hash- table implementation. Copy the code into the driver, so that the core code can be retired.For the record - I have no clue what legacy code uses the DRM hash-table for.No functional changes. However, the real solution for vmwgfx is to use Linux' generic hash-table functions.Would it be possible to use the Linux hash-table now rather than this mid-step where a lot of code is added to wmgfx only to be removed later?
I indeed considered to replace the hashtable with Linux' implementation. But the differences are slightly more involved than just API changes and a hashtable's performance often depends on its configuration. In the end, I didn't feel confident enough to make this change without doing damage.
If we go for this way then a todo item to fix this in wmgfx so someone can fix this later would be nice.
Sure. I'll add one. Zack already seems interested in having someone from his team working on it.
Best regards Thomas
Sam
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
