Am 2021-11-14 um 9:58 p.m. schrieb Bernard Zhao: > In function amdgpu_get_xgmi_hive, when kobject_init_and_add failed > There is a potential memleak if not call kobject_put. > > Signed-off-by: Bernard Zhao <bernard@xxxxxxxx> Reviewed-by: Felix Kuehling <Felix.Kuehling@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c > index 0fad2bf854ae..567df2db23ac 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c > @@ -386,6 +386,7 @@ struct amdgpu_hive_info *amdgpu_get_xgmi_hive(struct amdgpu_device *adev) > "%s", "xgmi_hive_info"); > if (ret) { > dev_err(adev->dev, "XGMI: failed initializing kobject for xgmi hive\n"); > + kobject_put(&hive->kobj); > kfree(hive); > hive = NULL; > goto pro_end;