On Sat, Nov 13, 2021 at 09:39:46PM +0100, Sam Ravnborg wrote: > Hi Claudio, > > On Sat, Nov 13, 2021 at 08:27:30PM +0100, Claudio Suarez wrote: > > The prefered way to log connectors is [CONNECTOR:id:name]. Change it in > > drm core programs. > > > > Suggested-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Signed-off-by: Claudio Suarez <cssk@xxxxxxxx> > > While touching all these logging calls, could you convernt them to the > newer drm_dbg_kms variants? > DRM_DEBUG_* are all deprecated. > Yes, I can, but it is recommended to do it in a different patch: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#separate-your-changes C&P: "Separate your changes Separate each logical change into a separate patch. For example, if your changes include both bug fixes and performance enhancements..." I will study and send a new separate patch with your suggestion. Best regards, Claudio Suarez