Re: [PATCH v5 7/7] drm/mediatek: Add mt8195 DisplayPort driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Markus,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on pza/reset/next linus/master v5.15 next-20211111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Markus-Schneider-Pargmann/drm-mediatek-Add-mt8195-DisplayPort-driver/20211021-172815
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/cacf71bb7517b3ea11577d354daf7024551aa948
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Markus-Schneider-Pargmann/drm-mediatek-Add-mt8195-DisplayPort-driver/20211021-172815
        git checkout cacf71bb7517b3ea11577d354daf7024551aa948
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/mediatek/mtk_dp.c:1031:6: error: no previous prototype for 'mtk_dp_initialize_settings' [-Werror=missing-prototypes]
    1031 | void mtk_dp_initialize_settings(struct mtk_dp *mtk_dp)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/device.h:15,
                    from include/linux/acpi.h:15,
                    from include/linux/i2c.h:13,
                    from include/drm/drm_crtc.h:28,
                    from include/drm/drm_atomic_helper.h:31,
                    from drivers/gpu/drm/mediatek/mtk_dp.c:7:
   drivers/gpu/drm/mediatek/mtk_dp.c: In function 'mtk_dp_hpd_sink_event':
>> include/drm/drm_print.h:412:39: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'ssize_t' {aka 'int'} [-Werror=format=]
     412 |         dev_##level##type((drm)->dev, "[drm] " fmt, ##__VA_ARGS__)
         |                                       ^~~~~~~~
   include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                              ^~~
   include/linux/dev_printk.h:150:58: note: in expansion of macro 'dev_fmt'
     150 |         dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                                          ^~~~~~~
   include/drm/drm_print.h:412:9: note: in expansion of macro 'dev_info'
     412 |         dev_##level##type((drm)->dev, "[drm] " fmt, ##__VA_ARGS__)
         |         ^~~~
   include/drm/drm_print.h:416:9: note: in expansion of macro '__drm_printk'
     416 |         __drm_printk((drm), info,, fmt, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~
   drivers/gpu/drm/mediatek/mtk_dp.c:1445:17: note: in expansion of macro 'drm_info'
    1445 |                 drm_info(mtk_dp->drm_dev,
         |                 ^~~~~~~~
>> include/drm/drm_print.h:412:39: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'ssize_t' {aka 'int'} [-Werror=format=]
     412 |         dev_##level##type((drm)->dev, "[drm] " fmt, ##__VA_ARGS__)
         |                                       ^~~~~~~~
   include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                              ^~~
   include/linux/dev_printk.h:150:58: note: in expansion of macro 'dev_fmt'
     150 |         dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                                          ^~~~~~~
   include/drm/drm_print.h:412:9: note: in expansion of macro 'dev_info'
     412 |         dev_##level##type((drm)->dev, "[drm] " fmt, ##__VA_ARGS__)
         |         ^~~~
   include/drm/drm_print.h:416:9: note: in expansion of macro '__drm_printk'
     416 |         __drm_printk((drm), info,, fmt, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~
   drivers/gpu/drm/mediatek/mtk_dp.c:1452:17: note: in expansion of macro 'drm_info'
    1452 |                 drm_info(mtk_dp->drm_dev,
         |                 ^~~~~~~~
>> include/drm/drm_print.h:412:39: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'ssize_t' {aka 'int'} [-Werror=format=]
     412 |         dev_##level##type((drm)->dev, "[drm] " fmt, ##__VA_ARGS__)
         |                                       ^~~~~~~~
   include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                              ^~~
   include/linux/dev_printk.h:150:58: note: in expansion of macro 'dev_fmt'
     150 |         dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                                          ^~~~~~~
   include/drm/drm_print.h:412:9: note: in expansion of macro 'dev_info'
     412 |         dev_##level##type((drm)->dev, "[drm] " fmt, ##__VA_ARGS__)
         |         ^~~~
   include/drm/drm_print.h:416:9: note: in expansion of macro '__drm_printk'
     416 |         __drm_printk((drm), info,, fmt, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~
   drivers/gpu/drm/mediatek/mtk_dp.c:1460:17: note: in expansion of macro 'drm_info'
    1460 |                 drm_info(mtk_dp->drm_dev, "Read link status failed: %ld\n",
         |                 ^~~~~~~~
   cc1: all warnings being treated as errors


vim +/mtk_dp_initialize_settings +1031 drivers/gpu/drm/mediatek/mtk_dp.c

  1030	
> 1031	void mtk_dp_initialize_settings(struct mtk_dp *mtk_dp)
  1032	{
  1033		mtk_dp_update_bits(mtk_dp, MTK_DP_TRANS_P0_342C,
  1034				   XTAL_FREQ_DP_TRANS_P0_DEFAULT,
  1035				   XTAL_FREQ_DP_TRANS_P0_MASK);
  1036		mtk_dp_update_bits(mtk_dp, MTK_DP_TRANS_P0_3540,
  1037				   BIT(FEC_CLOCK_EN_MODE_DP_TRANS_P0_SHIFT),
  1038				   FEC_CLOCK_EN_MODE_DP_TRANS_P0_MASK);
  1039		mtk_dp_update_bits(mtk_dp, MTK_DP_ENC0_P0_31EC,
  1040				   BIT(AUDIO_CH_SRC_SEL_DP_ENC0_P0_SHIFT),
  1041				   AUDIO_CH_SRC_SEL_DP_ENC0_P0_MASK);
  1042		mtk_dp_update_bits(mtk_dp, MTK_DP_ENC0_P0_304C, 0,
  1043				   SDP_VSYNC_RISING_MASK_DP_ENC0_P0_MASK);
  1044		mtk_dp_update_bits(mtk_dp, MTK_DP_TOP_IRQ_MASK, IRQ_MASK_AUX_TOP_IRQ,
  1045				   IRQ_MASK_AUX_TOP_IRQ);
  1046	}
  1047	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux