Hi Matt, > +static int > +intel_gt_tile_setup(struct intel_gt *gt, unsigned int id, phys_addr_t phys_addr) I have already r-b this, but, as I commented in patch 5, 'id' is redundant. Can we remove it? Andi > +{ > + int ret; > + > + intel_uncore_init_early(gt->uncore, gt->i915); > + > + ret = intel_uncore_setup_mmio(gt->uncore, phys_addr); > + if (ret) > + return ret; > + > + gt->phys_addr = phys_addr; > + > + return 0; > +} [...] > + /* We always have at least one primary GT on any device */ > + ret = intel_gt_tile_setup(&i915->gt, 0, phys_addr); > + if (ret) > + return ret; > + > + /* TODO: add more tiles */ > + return 0; > +}