Re: [PATCH] drm/msm/dsi: set default num_data_lanes

[Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>]

On 10/30/2021 10:08 AM, Philip Chen wrote:

> If "data_lanes" property of the dsi output endpoint is missing in
> the DT, num_data_lanes would be 0 by default, which could cause
> dsi_host_attach() to fail if dsi->lanes is set to a non-zero value
> by the bridge driver.
>
> According to the binding document of msm dsi controller, the
> input/output endpoint of the controller is expected to have 4 lanes.
> So let's set num_data_lanes to 4 by default.
>
> Signed-off-by: Philip Chen <philipchen@xxxxxxxxxxxx>
>     
    Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> ---
>
>  drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index c86b5090fae6..a32eb33dfc14 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -1696,6 +1696,8 @@ static int dsi_host_parse_lane_data(struct msm_dsi_host *msm_host,
>  	if (!prop) {
>  		DRM_DEV_DEBUG(dev,
>  			"failed to find data lane mapping, using default\n");
> +		/* Set the number of date lanes to 4 by default. */
> +		msm_host->num_data_lanes = 4;
>  		return 0;
>  	}
>  
>