Hi Julian, Thank you for catching this. On Mon, 25 Oct 2021 at 05:44, Julian Braha <julianbraha@xxxxxxxxx> wrote: > > When DRM_CHIPONE_ICN6211 is selected, and DRM_KMS_HELPER is not selected, > Kbuild gives the following warning: > > WARNING: unmet direct dependencies detected for DRM_PANEL_BRIDGE > Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && DRM_KMS_HELPER [=n] > Selected by [y]: > - DRM_CHIPONE_ICN6211 [=y] && HAS_IOMEM [=y] && DRM [=y] && DRM_BRIDGE [=y] && OF [=y] > > This is because DRM_CHIPONE_ICN6211 selects DRM_PANEL_BRIDGE > without depending on or selecting DRM_KMS_HELPER, > despite DRM_PANEL_BRIDGE depending on DRM_KMS_HELPER. > > This unmet dependency bug was detected by Kismet, > a static analysis tool for Kconfig. > Please advise if this is not the appropriate solution. Could you add a Fixes tag to this commit. ce517f18944e - drm: bridge: Add Chipone ICN6211 MIPI-DSI to RGB bridge With that, resubmit with my r-b. Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx> > > Signed-off-by: Julian Braha <julianbraha@xxxxxxxxx> > --- > drivers/gpu/drm/bridge/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > index 431b6e12a81f..a630cb8fd1c8 100644 > --- a/drivers/gpu/drm/bridge/Kconfig > +++ b/drivers/gpu/drm/bridge/Kconfig > @@ -30,6 +30,7 @@ config DRM_CDNS_DSI > config DRM_CHIPONE_ICN6211 > tristate "Chipone ICN6211 MIPI-DSI/RGB Converter bridge" > depends on OF > + select DRM_KMS_HELPER > select DRM_MIPI_DSI > select DRM_PANEL_BRIDGE > help > -- > 2.30.2 >
