Hi Angelo, Thanks for the review. On Thu, 2021-10-14 at 17:01 +0200, AngeloGioacchino Del Regno wrote: > > Add mtk-mutex support for mt8195 vdosys1. > > The vdosys1 path component contains ovl_adaptor, merge5, > > and dp_intf1. Ovl_adaptor is composed of several sub-elements, > > so change it to support multi-bit control. > > > > Signed-off-by: Nancy.Lin <nancy.lin@xxxxxxxxxxxx> > > --- > > drivers/soc/mediatek/mtk-mutex.c | 296 ++++++++++++++++++------ > > ------- > > 1 file changed, 175 insertions(+), 121 deletions(-) > > > > diff --git a/drivers/soc/mediatek/mtk-mutex.c > > b/drivers/soc/mediatek/mtk-mutex.c > > index 36502b27fe20..7767fedbd14f 100644 > > --- a/drivers/soc/mediatek/mtk-mutex.c > > +++ b/drivers/soc/mediatek/mtk-mutex.c > > @@ -29,113 +29,142 @@ > > > > #define INT_MUTEX BIT(1) > > > > -#define MT8167_MUTEX_MOD_DISP_PWM 1 > > This patch doesn't only add support for MT8195 vdosys1, but also > changes > all definitions to a different "format", and also changes the type > for > "mutex_mod" from int to long. > In reality, the actual functional change is minimal, compared to the > size of > this entire patch. > > Please, split this patch in two parts: one patch changing the defines > and > the mutex_mod type (specifying that it's a preparation for adding > support for > mt8195 vdosys1 mutex) and one patch adding such support. > > Thanks! > > Regards, > - Angelo OK, I will separate it into two patches. Regards, Nancy > >
