Re: [Intel-gfx] [PATCH 16/28] drm/i915: Rework context handling in hugepages selftests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Maarten,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next airlied/drm-next v5.15-rc6 next-20211021]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Maarten-Lankhorst/drm-i915-Fix-i915_request-fence-wait-semantics/20211021-183839
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-randconfig-a016-20211021 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/536df9470ecdddde67095f4f40f37752d944c343
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Maarten-Lankhorst/drm-i915-Fix-i915_request-fence-wait-semantics/20211021-183839
        git checkout 536df9470ecdddde67095f4f40f37752d944c343
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   In file included from drivers/gpu/drm/i915/gem/i915_gem_object.c:737:
>> drivers/gpu/drm/i915/gem/selftests/huge_pages.c:25:26: warning: no previous prototype for 'hugepage_ctx' [-Wmissing-prototypes]
      25 | struct i915_gem_context *hugepage_ctx(struct drm_i915_private *i915, struct file *file)
         |                          ^~~~~~~~~~~~


vim +/hugepage_ctx +25 drivers/gpu/drm/i915/gem/selftests/huge_pages.c

    24	
  > 25	struct i915_gem_context *hugepage_ctx(struct drm_i915_private *i915, struct file *file)
    26	{
    27		struct i915_gem_context *ctx = live_context(i915, file);
    28		struct i915_address_space *vm;
    29	
    30		if (IS_ERR(ctx))
    31			return ctx;
    32	
    33		vm = ctx->vm;
    34		if (vm)
    35			WRITE_ONCE(vm->scrub_64K, true);
    36	
    37		return ctx;
    38	}
    39	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux