Re: [PATCH 0/3] drm: Move several files from DRM core into modules

[Thomas Zimmermann <tzimmermann@xxxxxxx>]

Hi

Am 21.10.21 um 13:52 schrieb Daniel Vetter:
> On Wed, Oct 20, 2021 at 03:19:38PM +0200, Thomas Zimmermann wrote:
> > Move a number of files into modules and behind config options.
> >
> > So far, early boot graphics was provided by fbdev. With simpledrm, and
> > possibly other generic DRM drivers, it's now possible to have general
> > early-boot output with DRM. This requires the DRM core to be linked into
> > the kernel binary image.
> >
> > The reduction in size here is only ~1%, but the patchset is part of a
> > larger effort to reduce the size of the DRM core module.
> >
> > Thomas Zimmermann (3):
> >    drm: Build drm_irq.o only if CONFIG_DRM_LEGACY has been set
> >    drm: Link several object files into drm_kms_helper.ko
> >    drm: Move GEM memory managers into modules
>
> Assuming it all compiles still in all combos, on the series:
>
> Acked-by: Daniel Vetter <daniel.vetter@xxxxxxxx>

Thanks for the A-b. I built with DRM_LEGACY set and unset.

The GEM changes shouldn't be affected by the config. With the CMA 
helpers in a separate module, we could maybe remove 
CONFIG_DRM_KMS_CMA_HELPER and link drm_fb_cma_helper.o if 
CONFIG_DRM_KMS_HELPER has been selected.

Best regards
Thomas

> >   drivers/gpu/drm/Kconfig                |  4 ++--
> >   drivers/gpu/drm/Makefile               | 26 +++++++++++++++-----------
> >   drivers/gpu/drm/drm_gem_cma_helper.c   |  4 ++++
> >   drivers/gpu/drm/drm_gem_shmem_helper.c |  4 ++++
> >   drivers/gpu/drm/drm_irq.c              |  2 --
> >   5 files changed, 25 insertions(+), 15 deletions(-)
> >
> > --
> > 2.33.0

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

Attachment: OpenPGP_signature
Description: OpenPGP digital signature