On Wed, 20 Oct 2021, Khaled Almahallawy <khaled.almahallawy@xxxxxxxxx> wrote: > DPCD 248h name was changed from “PHY_TEST_PATTERN” in DP 1.4 to “LINK_QUAL_PATTERN_SELECT” in DP 2.0. Please use ASCII double quotes ". Please reflow the commit message to limit line lenghts to about 72 characters. > Also, DPCD 248h [6:0] is the same as DPCDs 10Bh/10Ch/10Dh/10Eh [6:0]. So removed the repeated definition of PHY patterns. > > Reference: “DPCD 248h/10Bh/10Ch/10Dh/10Eh Name/Description Consistency” > https://groups.vesa.org/wg/AllMem/documentComment/2738 > > Signed-off-by: Khaled Almahallawy <khaled.almahallawy@xxxxxxxxx> > --- > drivers/gpu/drm/drm_dp_helper.c | 6 +++--- > include/drm/drm_dp_helper.h | 13 +++---------- > 2 files changed, 6 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c > index ada0a1ff262d..c9c928c08026 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -2489,19 +2489,19 @@ int drm_dp_get_phy_test_pattern(struct drm_dp_aux *aux, > if (lanes & DP_ENHANCED_FRAME_CAP) > data->enhanced_frame_cap = true; > > - err = drm_dp_dpcd_readb(aux, DP_PHY_TEST_PATTERN, &data->phy_pattern); > + err = drm_dp_dpcd_readb(aux, DP_LINK_QUAL_PATTERN_SELECT, &data->phy_pattern); > if (err < 0) > return err; > > switch (data->phy_pattern) { > - case DP_PHY_TEST_PATTERN_80BIT_CUSTOM: > + case DP_LINK_QUAL_PATTERN_80BIT_CUSTOM: > err = drm_dp_dpcd_read(aux, DP_TEST_80BIT_CUSTOM_PATTERN_7_0, > &data->custom80, sizeof(data->custom80)); > if (err < 0) > return err; > > break; > - case DP_PHY_TEST_PATTERN_CP2520: > + case DP_LINK_QUAL_PATTERN_CP2520_PAT_1: > err = drm_dp_dpcd_read(aux, DP_TEST_HBR2_SCRAMBLER_RESET, > &data->hbr2_reset, > sizeof(data->hbr2_reset)); > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h > index afdf7f4183f9..ef915bb75bb4 100644 > --- a/include/drm/drm_dp_helper.h > +++ b/include/drm/drm_dp_helper.h > @@ -862,16 +862,9 @@ struct drm_panel; > # define DP_TEST_CRC_SUPPORTED (1 << 5) > # define DP_TEST_COUNT_MASK 0xf > > -#define DP_PHY_TEST_PATTERN 0x248 > -# define DP_PHY_TEST_PATTERN_SEL_MASK 0x7 > -# define DP_PHY_TEST_PATTERN_NONE 0x0 > -# define DP_PHY_TEST_PATTERN_D10_2 0x1 > -# define DP_PHY_TEST_PATTERN_ERROR_COUNT 0x2 > -# define DP_PHY_TEST_PATTERN_PRBS7 0x3 > -# define DP_PHY_TEST_PATTERN_80BIT_CUSTOM 0x4 > -# define DP_PHY_TEST_PATTERN_CP2520 0x5 > - > -#define DP_PHY_SQUARE_PATTERN 0x249 > +#define DP_LINK_QUAL_PATTERN_SELECT 0x248 Please add a comment here referencing where the values are. There are examples in the file. > + > +#define DP_PHY_SQUARE_PATTERN 0x249 > > #define DP_TEST_HBR2_SCRAMBLER_RESET 0x24A > #define DP_TEST_80BIT_CUSTOM_PATTERN_7_0 0x250 -- Jani Nikula, Intel Open Source Graphics Center
