Applied. thanks! On Fri, Oct 15, 2021 at 2:48 AM Qing Wang <wangqing@xxxxxxxx> wrote: > > show() must not use snprintf() when formatting the value to be > returned to user space. > > Fix the following coccicheck warning: > drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c:427: > WARNING: use scnprintf or sprintf. > > Signed-off-by: Qing Wang <wangqing@xxxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c > index 2834981..faf4011 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c > @@ -424,7 +424,7 @@ static ssize_t show_##name(struct device *dev, \ > struct drm_device *ddev = dev_get_drvdata(dev); \ > struct amdgpu_device *adev = drm_to_adev(ddev); \ > \ > - return snprintf(buf, PAGE_SIZE, "0x%08x\n", adev->field); \ > + return sysfs_emit(buf, "0x%08x\n", adev->field); \ > } \ > static DEVICE_ATTR(name, mode, show_##name, NULL) > > -- > 2.7.4 >
