Re: [PATCH v2 02/11] drm/msm/disp/dpu1: Add support for DSC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14-10-21, 17:40, Dmitry Baryshkov wrote:
> On 07/10/2021 10:08, Vinod Koul wrote:

> > +static void dpu_hw_dsc_config(struct dpu_hw_dsc *hw_dsc,
> > +			      struct msm_display_dsc_config *dsc, u32 mode)
> > +{
> > +	struct dpu_hw_blk_reg_map *c = &hw_dsc->hw;
> > +	u32 data, lsb, bpp;
> > +	u32 initial_lines = dsc->initial_lines;
> > +	bool is_cmd_mode = !(mode & BIT(2));
> 
> DSC_MODE_VIDEO

Updated

> > +static void dpu_hw_dsc_config_thresh(struct dpu_hw_dsc *hw_dsc,
> > +				     struct msm_display_dsc_config *dsc)
> 
> I thought that it might make sense to pass just drm_dsc_rc_range_parameters
> here, but it's a matter of personal preference. I won't insist on doing
> that.

This is called from encoder, so prefer not to have encoder invoke
dsc->drm->rc_range_params

So will keep this.

-- 
~Vinod



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux