On Mon, Oct 18, 2021 at 10:33 AM Caleb Connolly <caleb.connolly@xxxxxxxxxx> wrote: > > Hi all, > > On 18/10/2021 17:42, John Stultz wrote: > > On Mon, Oct 18, 2021 at 8:31 AM Rob Clark <robdclark@xxxxxxxxx> wrote: > >> > >> From: Rob Clark <robdclark@xxxxxxxxxxxx> > >> > >> Until we better understand the stability issues caused by frequent > >> frequency changes, lets limit them to a618. > >> > >> Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx> > >> --- > >> Caleb/John, I think this should help as a workaround for the power > >> instability issues on a630.. could you give it a try? > > > > While I hit it fairly often, I can't reliably reproduce the crash, but > > in limited testing this seems ok to me. > > I've not hit the crash so far, nor seen any other negative side > > effects over 5.14. > > > > So for what that's worth: > > Tested-by: John Stultz <john.stultz@xxxxxxxxxx> > > > > Caleb has better luck tripping this issue right away, so they can > > hopefully provide a more assured response. > This prevents the crash on the OnePlus 6 as the frequency can no longer go to zero. > > I would like to find a better solution that still allows proper idling on a630, but that can wait for 5.16. > > Tested-by: Caleb Connolly <caleb.connolly@xxxxxxxxxx> Thanks for testing, I've sent one last -fixes pull request with this patch BR, -R > > > > thanks > > -john > > > > -- > Kind Regards, > Caleb (they/them)
