Hi Marek, Thank you for the patch. On Sun, Oct 17, 2021 at 02:12:03AM +0200, Marek Vasut wrote: > The OnSemi FIN3385 Parallel-to-LVDS encoder has a dedicated input line to > select input pixel data sampling edge. Add DT property "pclk-sample", not > the same as the one used by display timings but rather the same as used by > media, to define the pixel data sampling edge. > > Signed-off-by: Marek Vasut <marex@xxxxxxx> > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > To: dri-devel@xxxxxxxxxxxxxxxxxxxxx > --- > V4: New patch split from combined V3 > V5: Rebase on recent linux-next > --- > .../bindings/display/bridge/lvds-codec.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > index 1faae3e323a4..708de84ac138 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > @@ -79,6 +79,14 @@ properties: > - port@0 > - port@1 > > + pclk-sample: > + description: > + Data sampling on rising or falling edge. > + enum: > + - 0 # Falling edge > + - 1 # Rising edge > + default: 0 > + Shouldn't this be moved to the endpoint, the same way data-mapping is defined as an endpoint property ? > powerdown-gpios: > description: > The GPIO used to control the power down line of this device. > @@ -102,6 +110,16 @@ then: > properties: > data-mapping: false > > +if: > + not: > + properties: > + compatible: > + contains: > + const: lvds-encoder > +then: > + properties: > + pclk-sample: false > + > required: > - compatible > - ports -- Regards, Laurent Pinchart
